fix(deepdata): correct Zback channel in sort(), change int pixel to int64_t#5241
Open
luna-y-kim wants to merge 1 commit into
Open
fix(deepdata): correct Zback channel in sort(), change int pixel to int64_t#5241luna-y-kim wants to merge 1 commit into
luna-y-kim wants to merge 1 commit into
Conversation
…nt64_t - Fix sort() using the front Z channel instead of Zback channel. - Widen pixel indices from int to int64_t (leftover from AcademySoftwareFoundation#2363). - Cleanup unreachable branches in merge_overlaps(). Signed-off-by: Luna Kim <177369799+luna-y-kim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix sort() using the front Z channel instead of Zback channel.
Cleanup unreachable branches in merge_overlaps().
Widen pixel indices from int to int64_t (follow-up to Make DeepData more safe for huge images where pixels() could overflow an int #2363).
→ The
srcpixelparam ofDeepData::merge_deep_pixels()also needs to be fixed frominttoint64_t, but it breaks compatibility for programs already built (ABI check fail), so it is left asintfor now. The issue is submitted (#5242).Tests
Modified the
DeepData::sorttest to include samples with a tied front Z, so it verifies the Zback fallback.Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.